Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanupJobResource #1150

Merged
merged 3 commits into from
Mar 16, 2024
Merged

fix: cleanupJobResource #1150

merged 3 commits into from
Mar 16, 2024

Conversation

ANGkeith
Copy link
Collaborator

@ANGkeith ANGkeith commented Mar 16, 2024

docker rm and docker volume rm supports multiple args.

this should probably be slightly more efficient.

Not too sure why, but the current cleanup also seemed to leave some docker volume undeleted

To replicated the issue:

# .gitlab-ci.yml
job0:
  image: bash
  script: echo hi
for i in $(seq 1 9); do
 gitlab-ci-local
done

Run docker volume ls and observe that there are remaing xxxxx-tmp volume that are not cleaned up

src/index.ts Show resolved Hide resolved
@ANGkeith ANGkeith changed the title fix: container cleanup fix: cleanupJobResource Mar 16, 2024
Copy link

sonarcloud bot commented Mar 16, 2024

@firecow firecow merged commit e06abe8 into master Mar 16, 2024
10 checks passed
@firecow firecow deleted the fix/container-cleanup branch March 16, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants