Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement shell executor no image #1186

Merged
merged 3 commits into from
Apr 15, 2024

Conversation

ANGkeith
Copy link
Collaborator

@ANGkeith ANGkeith commented Apr 15, 2024

closes #1171

merge #1186 in first

@ANGkeith ANGkeith force-pushed the feat/Implement-shell-executor-no-image branch from 44c99a5 to c55d971 Compare April 15, 2024 17:12
Copy link

sonarcloud bot commented Apr 15, 2024

Copy link
Owner

@firecow firecow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ❤️ the time you take in writing the tests 😄

It makes it so easy to approve

@firecow firecow merged commit c4a6f26 into master Apr 15, 2024
10 checks passed
@firecow firecow deleted the feat/Implement-shell-executor-no-image branch April 15, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement --shell-executor-no-image
2 participants