Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CI_JOB_NAME_SLUG #651

Merged
merged 5 commits into from
Nov 9, 2022
Merged

Add CI_JOB_NAME_SLUG #651

merged 5 commits into from
Nov 9, 2022

Conversation

firecow
Copy link
Owner

@firecow firecow commented Nov 8, 2022 •
edited

closes #650

@firecow firecow self-assigned this Nov 8, 2022
@firecow firecow requested a review from atli-c November 8, 2022 13:58
atli-c
atli-c requested changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@atli-c atli-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes trailing hyphen on slugs. Adds a few more variables

src/job.ts Outdated Show resolved Hide resolved
src/job.ts Outdated Show resolved Hide resolved
src/job.ts Show resolved Hide resolved
@atli-c
Copy link
Collaborator

atli-c commented Nov 8, 2022 •
edited

Also:

// in src/predefined-variables.ts
CI_COMMIT_AUTHOR: `${gitData.user["GITLAB_USER_NAME"]} <${gitData.user["GITLAB_USER_NAME"]}>`

@atli-c
Copy link
Collaborator

atli-c commented Nov 8, 2022

Solves #650

firecow and others added 2 commits November 8, 2022 15:34
@firecow @atli-c
Update src/job.ts
c4dd003 
Co-authored-by: Atli Christiansen <atli.christiansen@gmail.com>
@firecow @atli-c
Update src/job.ts
914a4d7 
Co-authored-by: Atli Christiansen <atli.christiansen@gmail.com>
@atc-cegodk atc-cegodk mentioned this pull request Nov 8, 2022
Open
atc-cegodk
atc-cegodk approved these changes Nov 8, 2022
View reviewed changes
Copy link

@atc-cegodk atc-cegodk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/job.ts Show resolved Hide resolved
@firecow
Copy link
Owner Author

firecow commented Nov 8, 2022

@atc-cegodk I cannot merge for some reason.
Even though I've resolved all comments.

@sonarcloud
Copy link

sonarcloud bot commented Nov 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

atli-c
atli-c approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@atli-c atli-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@firecow firecow merged commit 3f65ce5 into master Nov 9, 2022
@firecow firecow deleted the issue-650 branch November 9, 2022 05:24
firecow added a commit that referenced this pull request Nov 16, 2022
@firecow @atli-c
Add CI_JOB_NAME_SLUG (#651)
b1518d6 
* Add CI_JOB_NAME_SLUG

* Use proper regex n' stuff to get proper CI_JOB_NAME_SLUG

* Update src/job.ts

Co-authored-by: Atli Christiansen <atli.christiansen@gmail.com>

* Update src/job.ts

Co-authored-by: Atli Christiansen <atli.christiansen@gmail.com>

* Fix bug in predefined-variables.ts

Co-authored-by: Atli Christiansen <atli.christiansen@gmail.com>
Former-commit-id: 3f65ce5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atli-c atli-c atli-c approved these changes

@atc-cegodk atc-cegodk atc-cegodk approved these changes

Assignees

@firecow firecow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing predefined variables. E.g. CI_JOB_NAME_SLUG
3 participants
@firecow @atli-c @atc-cegodk