Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support artifacts:when:always #652

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Support artifacts:when:always #652

merged 1 commit into from
Nov 8, 2022

Conversation

kouk
Copy link
Collaborator

@kouk kouk commented Nov 8, 2022

Currently when artifacts:when is set to always the artifacts of a failed job aren't copied out.

Ref: https://docs.gitlab.com/ee/ci/yaml/#artifactswhen

Currently when artifacts:when is set to always the artifacts of a failed
job aren't copied out.
Copy link
Owner

@firecow firecow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic stuff. You want a contributor invite @kouk ?

@firecow firecow merged commit 1aec9f3 into firecow:master Nov 8, 2022
@kouk
Copy link
Collaborator Author

kouk commented Nov 8, 2022

@firecow my team's using your tool heavily, so yeah, I could help out for sure. Although I must tell you I am no typescript developer. In fact this is the very first time I've written a line of TS. Kind of winging it with my knowledge of JS.

firecow pushed a commit that referenced this pull request Nov 16, 2022
Currently when artifacts:when is set to always the artifacts of a failed
job aren't copied out.

Former-commit-id: 1aec9f3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants