Update client/swagger.yaml from 0.21.0 to b922c7d #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kzys
commented
May 5, 2020
|
Let me terminate the EC2 instance (i-0b150441a0ae63644). It seems unhealthy. https://buildkite.com/firecracker-microvm/firecracker-go-sdk/builds/873 |
kzys
force-pushed
the
fc-master
branch
3 times, most recently
from
0ecfdb0
to
f1cdac6
Compare
kzys
commented
May 5, 2020
kzys
commented
May 5, 2020
kzys
changed the title
kzys
force-pushed
the
fc-master
branch
4 times, most recently
from
0fa8f41
to
6303571
Compare
kzys
changed the title
And "make generate" to generate files. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
The SDK's master no longer works with 0.21.x. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
…ork pre-boot These methods use PATCH internally, which no longer work pre-boot. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com>
kzys
changed the title
kzys
commented
Jul 13, 2020
IRCody
reviewed
Jul 13, 2020
machine.go
Outdated
| } | ||
|
|
||
| func (m *Machine) setupMetrics(ctx context.Context) error { | ||
| fmt.Println("setupMetrics") |
There was a problem hiding this comment.
m.logger.printf if we still want this message?
Previously Firecracker had a single operation to set logging and metrics, and the fields specifically mentioned "FIFO". Now the operation is broken into two and it doesn't mention "FIFO" anymore. This change keeps MetricsFifo and LogFifo to be backward-compatible. Signed-off-by: Kazuyoshi Kato <katokazu@amazon.com> fix
IRCody
approved these changes
Jul 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
NA
Description of changes:
Firecracker is making a few breaking changes. I'd like to estimate how much changes we may need, before their official release.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.