Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added snapshot documentation + pipeline example code #431

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

sondavidb
Copy link
Contributor

@sondavidb sondavidb commented Jul 29, 2022

Signed-off-by: David Son davbson@amazon.com

Issue #, if available:
#423

Description of changes:
Documenting changes made in #414 as well as creating a working example of snapshots in the SDK that is tested in the pipeline to ensure relevancy. It may be redundant due to it being very similar to TestLoadSnapshot() in machine.go but I feel having a prepackaged way for users to easily test snapshotting capabilities is very useful. Feel free to discuss below.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

examples/cmd/snapshotting/README.md Outdated Show resolved Hide resolved
docs/snapshotting.md Outdated Show resolved Hide resolved
examples/cmd/snapshotting/example_demo.go Outdated Show resolved Hide resolved
docs/snapshotting.md Outdated Show resolved Hide resolved
examples/cmd/snapshotting/Makefile Outdated Show resolved Hide resolved
examples/cmd/snapshotting/README.md Outdated Show resolved Hide resolved
docs/snapshotting.md Outdated Show resolved Hide resolved
@sondavidb sondavidb force-pushed the snapshot-docs branch 7 times, most recently from 2163436 to 239afca Compare August 1, 2022 22:41
examples/cmd/snapshotting/example_demo.go Outdated Show resolved Hide resolved
examples/cmd/snapshotting/example_demo.go Outdated Show resolved Hide resolved
examples/cmd/snapshotting/example_demo.go Outdated Show resolved Hide resolved
examples/cmd/snapshotting/example_demo.go Show resolved Hide resolved
examples/cmd/snapshotting/example_demo.go Outdated Show resolved Hide resolved
examples/cmd/snapshotting/example_demo.go Outdated Show resolved Hide resolved
docs/snapshotting.md Outdated Show resolved Hide resolved
Signed-off-by: David Son <davbson@amazon.com>
@sondavidb sondavidb merged commit b6809bb into firecracker-microvm:main Aug 2, 2022
@sondavidb sondavidb deleted the snapshot-docs branch August 2, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants