Release v1.0.0 #444
Merged
Release v1.0.0 #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 29, 2022
Closed
Closed
CHANGELOG.md
Outdated
| * Adds snapshot loading capabilities. (#414) | ||
| * Adds ability to change engine IO type. (#411) | ||
| * Adds ability to get Firecracker Version. (#410) | ||
| * Deprecates pkg/errors. (#404) |
There was a problem hiding this comment.
I think we can exclude this change from the changelog. A user probably wouldn't care.
CHANGELOG.md
Outdated
| @@ -1,3 +1,16 @@ | |||
| # 1.0.0 | |||
| * Removes unnecessary requirements for loading snapshots. (#433) | |||
There was a problem hiding this comment.
This was a bug fix for a feature added in this release so can probably exclude it.
CHANGELOG.md
Outdated
Comment on lines
3
to
5
| * Adds snapshot loading capabilities. (#414) | ||
| * Adds ability to change engine IO type. (#411) | ||
| * Adds ability to get Firecracker Version. (#410) |
There was a problem hiding this comment.
Suggested change
| * Adds snapshot loading capabilities. (#414) | |
| * Adds ability to change engine IO type. (#411) | |
| * Adds ability to get Firecracker Version. (#410) | |
| * Added support for load snapshot | |
| * Added support for set drive IO engine type | |
| * Added support for get Firecracker version |
CHANGELOG.md
Outdated
Comment on lines
1
to
10
| # 1.0.0 | ||
| * Added support for load snapshot. (#414) | ||
| * Added support for set drive IO engine type. (#411) | ||
| * Added support for get Firecracker version. (#410) | ||
| * Adds a DriveOpt func for configuring CacheType. (#401) | ||
| * Adds GetExportVMConfig to read the /vm/config endpoint. (#400) | ||
| * Adds ability to allow passing cgroup-version to jailer. (#399) | ||
| * Adds support for the MMDS configuration. (#290) | ||
| * Adds PauseVM, ResumeVM, and CreateSnapshot capabilities. (#278) | ||
| * Fixes InitrdPath usage. (#295) |
There was a problem hiding this comment.
A few comments I had:
- We should settle on a single tense. I prefer past e.g. "Added" over "Adds" Thoughts?
- Should we group like features? e.g. Added support for create and load snapshot (Implement PauseVM, ResumeVM, and CreateSnapshot #278, Implemented snapshot loading capabilities #414)
There was a problem hiding this comment.
1.) I do think that makes sense. I just wanted to be more in-line with previous change logs in older releases as they also use present tense.
2.) I agree. That is more comprehensive.
There was a problem hiding this comment.
Is the consensus that we use past tense for the changelog?
CHANGELOG.md
Outdated
| * Added GetExportVMConfig to read the /vm/config endpoint. (#400) | ||
| * Added ability to allow passing cgroup-version to jailer. (#399) | ||
| * Added support for the MMDS configuration. (#290) | ||
| * Added PauseVM, ResumeVM, CreateSnapshot and LoadSnapshot capabilities. (#278) |
There was a problem hiding this comment.
Wouldn't we need the second link because load snapshot came in a separate PR?
austinvazquez
approved these changes
Aug 31, 2022
ginglis13
approved these changes
Aug 31, 2022
Signed-off-by: Yasin Turan <turyasin@amazon.com>
austinvazquez
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yasin Turan turyasin@amazon.com
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.