Enable resuming snapshot for jailed firecracker #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albinvass
force-pushed
the
fix-loading-snapshot
branch
from
f5d23c9
to
f301638
Compare
albinvass
force-pushed
the
fix-loading-snapshot
branch
from
4d7df63
to
6083026
Compare
albinvass
force-pushed
the
fix-loading-snapshot
branch
from
6083026
to
7699d06
Compare
Signed-off-by: Albin Vass <albinvass@gmail.com>
Signed-off-by: Albin Vass <albinvass@gmail.com>
albinvass
force-pushed
the
fix-loading-snapshot
branch
from
7699d06
to
7d76793
Compare
swagatbora90
reviewed
Jul 9, 2024
| @@ -426,6 +426,24 @@ func LinkFilesHandler(kernelImageFileName string) Handler { | |||
| m.Cfg.Drives[i].PathOnHost = String(driveFileName) | |||
| } | |||
|
|
|||
| if m.Cfg.hasSnapshot() { | |||
There was a problem hiding this comment.
hasSnapshot returns true if either snapshotPath or memFilePath is non-empty, so we should check if the individual file paths are non-empty, before creating the file link.
swagatbora90
reviewed
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This links the memory and snapshot files into the root of the jail and fixes an issue where
WithSnapshotsoverrides the injectedLinkFilesHandler.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.