Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jailer doesn't ensure correct permissions for /dev inside the jail #1802

Closed
aghecenco opened this issue Apr 20, 2020 · 0 comments
Closed

jailer doesn't ensure correct permissions for /dev inside the jail #1802

aghecenco opened this issue Apr 20, 2020 · 0 comments
Assignees
Labels
Priority: High Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled Type: Bug Indicates an unexpected problem or unintended behavior

Comments

@aghecenco
Copy link
Contributor

The jailer creates the /dev, /dev/net and /run folders inside the jail but doesn't ensure that they're accessible for the unprivileged user which firecracker will run under. This can lead to errors when attempting to open devices (dev/kvm and /dev/net/tun), even if the permissions on the devices themselves are correctly set.

fs::create_dir_all(path).map_err(|e| Error::CreateDir(PathBuf::from(path), e))?;

@aghecenco aghecenco self-assigned this Apr 20, 2020
@aghecenco aghecenco added Priority: High Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled Type: Bug Indicates an unexpected problem or unintended behavior labels Apr 20, 2020
aghecenco added a commit to aghecenco/firecracker that referenced this issue Apr 20, 2020
Fixes firecracker-microvm#1802

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
aghecenco added a commit to aghecenco/firecracker that referenced this issue Apr 20, 2020
Fixes firecracker-microvm#1802

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
aghecenco added a commit to aghecenco/firecracker that referenced this issue Apr 20, 2020
Fixes firecracker-microvm#1802

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
aghecenco added a commit to aghecenco/firecracker that referenced this issue Apr 20, 2020
Fixes firecracker-microvm#1802

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
aghecenco added a commit to aghecenco/firecracker that referenced this issue Apr 23, 2020
Fixes firecracker-microvm#1802

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
aghecenco added a commit to aghecenco/firecracker that referenced this issue Apr 23, 2020
Fixes firecracker-microvm#1802

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
aghecenco added a commit to aghecenco/firecracker that referenced this issue Apr 23, 2020
Fixes firecracker-microvm#1802

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
aghecenco added a commit to aghecenco/firecracker that referenced this issue Apr 29, 2020
Fixes firecracker-microvm#1802

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
aghecenco added a commit to aghecenco/firecracker that referenced this issue Apr 29, 2020
Fixes firecracker-microvm#1802

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
aghecenco added a commit to aghecenco/firecracker that referenced this issue May 6, 2020
Fixes firecracker-microvm#1802

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
aghecenco added a commit to aghecenco/firecracker that referenced this issue May 7, 2020
Fixes firecracker-microvm#1802

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
aghecenco added a commit to aghecenco/firecracker that referenced this issue May 8, 2020
Fixes firecracker-microvm#1802

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
aghecenco added a commit to aghecenco/firecracker that referenced this issue May 8, 2020
Fixes firecracker-microvm#1802

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
aghecenco added a commit to aghecenco/firecracker that referenced this issue May 13, 2020
Fixes firecracker-microvm#1802

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
aghecenco added a commit to aghecenco/firecracker that referenced this issue May 13, 2020
Fixes firecracker-microvm#1802

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
bbros-dev pushed a commit to BegleyBrothers/firecracker that referenced this issue May 16, 2020
Fixes firecracker-microvm#1802

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
gbionescu pushed a commit to jabedude/firecracker that referenced this issue Jun 5, 2020
Fixes firecracker-microvm#1802

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
dianpopa pushed a commit to dianpopa/firecracker that referenced this issue Aug 5, 2020
Fixes firecracker-microvm#1802

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
dianpopa pushed a commit that referenced this issue Aug 5, 2020
Fixes #1802

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Development

No branches or pull requests

1 participant