Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Memory monitor logic does not support multiple memory regions layout #3349

Closed
dianpopa opened this issue Jan 4, 2023 · 0 comments · Fixed by #3399
Closed

[Bug] Memory monitor logic does not support multiple memory regions layout #3349

dianpopa opened this issue Jan 4, 2023 · 0 comments · Fixed by #3399
Labels
Type: Bug Indicates an unexpected problem or unintended behavior

Comments

@dianpopa
Copy link
Contributor

dianpopa commented Jan 4, 2023

Describe the bug

Some intermittent failures can be noticed for tests that configure microVMs that exceed the one memory region layout on x86.
Like test_create_large_diff_snapshot.
The test fails only sometimes because most of the times the memory monitor does not get a chance to run a second time (we have a 1s gap between runs) before the test finishes.

To Reproduce

  • decrease MEMORY_SAMPLE_TIMEOUT_S to 0.5
  • run test_create_large_diff_snapshot

Expected behaviour

  • aforementioned test passes all the time
@dianpopa dianpopa added the Type: Bug Indicates an unexpected problem or unintended behavior label Jan 4, 2023
dianpopa added a commit to dianpopa/firecracker that referenced this issue Jan 4, 2023
@dianpopa
[tests] disable mem_monitor for big microVMs
8e9a2af 
See GitHub issue firecracker-microvm#3349.

Signed-off-by: Diana Popa <dpopa@amazon.com>
dianpopa added a commit that referenced this issue Jan 5, 2023
@dianpopa
[tests] disable mem_monitor for big microVMs
26f02d1 
See GitHub issue #3349.

Signed-off-by: Diana Popa <dpopa@amazon.com>
dianpopa added a commit to dianpopa/firecracker that referenced this issue Jan 10, 2023
@dianpopa
tests: disable mem monitor for big microVMs
d68ba54 
If size of the microVM requires 2 memory regions
(only on x86), then disable memory monitor.
This is a temporary solution till firecracker-microvm#3349 is fixed.

Signed-off-by: Diana Popa <dpopa@amazon.com>
Merged
10 tasks
dianpopa added a commit to dianpopa/firecracker that referenced this issue Jan 11, 2023
@dianpopa
tests: disable mem monitor for big microVMs
58f6508 
If size of the microVM requires 2 memory regions
(only on x86), then disable memory monitor.
This is a temporary solution till firecracker-microvm#3349 is fixed.

Signed-off-by: Diana Popa <dpopa@amazon.com>
dianpopa added a commit that referenced this issue Jan 12, 2023
@dianpopa
tests: disable mem monitor for big microVMs
5b75956 
If size of the microVM requires 2 memory regions
(only on x86), then disable memory monitor.
This is a temporary solution till #3349 is fixed.

Signed-off-by: Diana Popa <dpopa@amazon.com>
@kalyazin kalyazin mentioned this issue Jan 26, 2023
Merged
5 tasks
jkrshnmenon pushed a commit to jkrshnmenon/firecracker that referenced this issue Mar 7, 2023
@dianpopa
tests: disable mem monitor for big microVMs
8d5e1ab 
If size of the microVM requires 2 memory regions
(only on x86), then disable memory monitor.
This is a temporary solution till firecracker-microvm#3349 is fixed.

Signed-off-by: Diana Popa <dpopa@amazon.com>
JonathanWoollett-Light pushed a commit to JonathanWoollett-Light/firecracker that referenced this issue Mar 17, 2023
@dianpopa @andreitraistaru
[tests] disable mem_monitor for big microVMs
077811b 
See GitHub issue firecracker-microvm#3349.

Signed-off-by: Diana Popa <dpopa@amazon.com>
JonathanWoollett-Light pushed a commit to JonathanWoollett-Light/firecracker that referenced this issue Mar 17, 2023
@dianpopa @andreitraistaru
tests: disable mem monitor for big microVMs
7cec8b3 
If size of the microVM requires 2 memory regions
(only on x86), then disable memory monitor.
This is a temporary solution till firecracker-microvm#3349 is fixed.

Signed-off-by: Diana Popa <dpopa@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Indicates an unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support multiple regions in memory monitor kalyazin/firecracker
1 participant
@dianpopa