Update code coverage to grcov #3353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanWoollett-Light
force-pushed
the
grcov
branch
from
ecc6061
to
3e75058
Compare
JonathanWoollett-Light
added
Quality: CI
Status: Awaiting review
JonathanWoollett-Light
force-pushed
the
grcov
branch
2 times, most recently
from
11ebc1c
to
c230d1d
Compare
roypat
reviewed
Jan 6, 2023
|
Closes #3207 |
JonathanWoollett-Light
force-pushed
the
grcov
branch
5 times, most recently
from
ec3d316
to
b75db71
Compare
pb8o
reviewed
Jan 9, 2023
JonathanWoollett-Light
force-pushed
the
grcov
branch
10 times, most recently
from
1913e51
to
29786a5
Compare
pb8o
reviewed
Jan 10, 2023
JonathanWoollett-Light
force-pushed
the
grcov
branch
4 times, most recently
from
c64de5a
to
95f4cc0
Compare
pb8o
previously approved these changes
Jan 10, 2023
roypat
reviewed
Jan 10, 2023
JonathanWoollett-Light
force-pushed
the
grcov
branch
from
95f4cc0
to
25003b0
Compare
roypat
previously approved these changes
Jan 10, 2023
Moved code coverage from kcov to grcov. Updated `verify_dependencies.rs` as no longer proxying through `cargo kcov` and the environment variable `CARGO_MANIFEST_DIR` is now always set. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk> Co-authored-by: Pablo Barbáchano <pablob@amazon.com>
Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
We don't need to specify `+"stable"` in `cargo install +"stable" cargo-audit` as this will be the default. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
JonathanWoollett-Light
force-pushed
the
grcov
branch
from
25003b0
to
0f95821
Compare
roypat
approved these changes
Jan 10, 2023
pb8o
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Changes code coverage to grcov.
Reason
kcov outputs inaccurate coverage.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
git commit -s).unsafecode is documented.CHANGELOG.md.TODOs link to an issue.rust-vmm.