Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Move arch_gen into module under vmm #3528

Merged
merged 1 commit into from Mar 29, 2023
Merged

fix: Move arch_gen into module under vmm #3528

merged 1 commit into from Mar 29, 2023

Conversation

JonathanWoollett-Light
Copy link
Contributor

@JonathanWoollett-Light JonathanWoollett-Light commented Mar 14, 2023 •
edited

Changes

Moved arch_gen into module under vmm.

Reason

See #3079

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.
  • This functionality cannot be added in rust-vmm.

@JonathanWoollett-Light JonathanWoollett-Light force-pushed the arch_gen-module branch 7 times, most recently from 7ef3665 to c98ecdb Compare March 14, 2023 16:46
@JonathanWoollett-Light JonathanWoollett-Light mentioned this pull request Mar 14, 2023
Merged
9 tasks
@JonathanWoollett-Light JonathanWoollett-Light added Type: Fix Indicates a fix to existing code Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Blocked Indicates that an issue or pull request cannot currently be worked on and removed Codebase: Architecture labels Mar 23, 2023
@JonathanWoollett-Light
Copy link
Contributor Author

Blocked on merging of either #3530 or #3534.

@JonathanWoollett-Light JonathanWoollett-Light added Status: Awaiting review Indicates that a pull request is ready to be reviewed and removed Status: Blocked Indicates that an issue or pull request cannot currently be worked on labels Mar 28, 2023
@JonathanWoollett-Light
Copy link
Contributor Author

Unblocked as #3530 has merged.

zulinx86
zulinx86 requested changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@zulinx86 zulinx86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might want to update tools/bindgen.sh so that it outputs into src/vmm/src/arch_gen/.

@JonathanWoollett-Light
Copy link
Contributor Author

You might want to update tools/bindgen.sh so that it outputs into src/vmm/src/arch_gen/.

Fixed.

@JonathanWoollett-Light
fix: Move arch_gen into module under vmm
e39471c 
Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
@JonathanWoollett-Light JonathanWoollett-Light merged commit e0c9ac9 into firecracker-microvm:main Mar 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShadowCurse ShadowCurse ShadowCurse approved these changes

@zulinx86 zulinx86 zulinx86 approved these changes

Assignees

@JonathanWoollett-Light JonathanWoollett-Light

Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Fix Indicates a fix to existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JonathanWoollett-Light @ShadowCurse @zulinx86