test: Remove test_ensure_mod_tests
#3534
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current implementation of the test does not cover most error cases. A full solution would need to consider the Rust AST. In the worst case a test gets included in coverage and raises the coverage slightly higher than it should be, this is not a significant impact. The test does check some cases, this may be better than no test at all, however given the impact it is not significant enough to warrant the complication. Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
JonathanWoollett-Light
force-pushed
the
remove-test-ensure-mod-tests
branch
from
8be9a34
to
9705445
Compare
JonathanWoollett-Light
added
the
Status: Awaiting review
|
Actually (really sorry for investigating this so piece-wise), there seems to be cargo test --all --quiet -- --list --format=terse | grep -v <exclude list> | grep -v "::tests::"might get us what we want |
JonathanWoollett-Light
added
Type: Fix
9 tasks
|
We decided to go with #3530 instead. |
This was referenced May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Remove
test_ensure_mod_tests.Reason
The current implementation of the test does not cover most error cases.
A full solution would need to consider the Rust AST. In the worst case a test gets included in coverage and raises the coverage slightly higher than it should be, this is not a significant impact.
The test does check some cases, this may be better than no test at all, however given the impact it is not significant enough to warrant the complication.
I also posted rust-lang/rust-clippy#10506.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.