Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>

Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>

This provides support for breakpoints

Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>

The KVM_SET_GUEST_DEBUG ioctl enables the handling of a trap signal,
generated when execution reaches a breakpoint or single-stepping
is enabled. An alternative to this seccomp rule would be
requiring the execution of the guest under GDB to be performed
with seccomp disabled

Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>

Improve readability, define proper error types and add support
for early-boot virtual address access

Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>

Cases in which PDPTE's PS flag would be 1 or PDE's PS flag
would be 0 were not properly treated.
This problem only manifested itself later in the boot process
(e.g., register_virtio_device for a stack address)

Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>

Removed the option of setting breakpoints at linear addresses in
early boot. The support for it contained a work-around and not
all inconsistencies at the client could have been solved on the
server side (e.g.: "info breakpoints" would not display such a
breakpoint as "hit" when it was the case).

Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>

Specifying the --debugger argument will enable GDB guest debugging
for the current session; not specifying it leads to normal execution

Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>

Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>

Adding a "debugger_enabled" argument to some public functions
impacted some unit and integration tests

Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>

Change virt_to_phys() function signature so that it only
receives the data it actually needs

Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>

This unittest verifies the virtual-to-physical address
translation is properly performed in the early boot process
of a kernel

Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>

Before, a target remote command would start the guest VM
and would let it wait at the entry point. This commit
offers the user the responsibility of issuing a continue
command in the beginning so that the VM starts and executes
until reaching the entry point. This is also aligned
with the practice used in IDEs of starting the debugging
process with a default continue.

Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>

Add comments, remove magic numbers, etc.
Also, add support for setting multiple registers

Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>

This update allows for connection on any host interface and
on a port that is easily accessible for a EC2 host

Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>

Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>

Add a few code comments and fix some minor code style issues

Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>

Signed-off-by: Marius-Cristian Baciu <baciumar@amazon.com>

Signed-off-by: kumargu <kumargu@amazon.com>

Signed-off-by: kumargu <kumargu@amazon.com>

Signed-off-by: kumargu <kumargu@amazon.com>

Signed-off-by: kumargu <kumargu@amazon.com>

Signed-off-by: kumargu <kumargu@amazon.com>

Signed-off-by: kumargu <kumargu@amazon.com>