Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supress atty cargo audit warning #3283

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

roypat
Copy link
Contributor

@roypat roypat commented Nov 22, 2022

Signed-off-by: Patrick Roy roypat@amazon.co.uk

Changes

Suppress the warning cargo audit throws about atty

Reason

This warning is currently blocking our PR CI, and there is no remedy available, as there is no patched version of the atty crate available, and we do not know how long it will take for criterion to remove the dependency.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.

PR Checklist

  • All commits in this PR are signed (git commit -s).
  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • New unsafe code is documented.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

  • This functionality can be added in rust-vmm.

dianpopa
dianpopa previously approved these changes Nov 22, 2022
zulinx86
zulinx86 previously approved these changes Nov 22, 2022
This warning is currently blocking our PR CI, and there is no remedy
available, as there is no patched version of the atty crate available,
and we do not know how long it will take for criterion to remove the
dependency.

Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
@dianpopa dianpopa merged commit 9adb2b2 into firecracker-microvm:main Nov 22, 2022
@roypat roypat deleted the supress-atty-warning branch April 15, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants