Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use thiserror::Error for more packages #3316

Merged

Conversation

cm-iwata
Copy link
Contributor

@cm-iwata cm-iwata commented Dec 12, 2022

Changes

changed these packages implementation to use thiserror::Error instead implements fmt::Display.

  • api_server
  • mmds
  • devices
  • seccompiler
  • jailer

Reason

This PR will fix partof #3278

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.

PR Checklist

  • All commits in this PR are signed (git commit -s).
  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • New unsafe code is documented.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.

  • This functionality can be added in rust-vmm.

@cm-iwata cm-iwata force-pushed the chore/3278_use_thiserror branch 2 times, most recently from 1f95cb0 to 9a68031 Compare December 21, 2022 00:37
dianpopa
dianpopa previously approved these changes Dec 21, 2022
@JonathanWoollett-Light
Copy link
Contributor

@cm-iwata The PR needs to be rebased, could you please rebase onto main.

Signed-off-by: Tomoya <iwata.tomoya@classmethod.jp>
Signed-off-by: Tomoya <iwata.tomoya@classmethod.jp>
Signed-off-by: Tomoya <iwata.tomoya@classmethod.jp>
Signed-off-by: Tomoya <iwata.tomoya@classmethod.jp>
Signed-off-by: Tomoya <iwata.tomoya@classmethod.jp>
@cm-iwata
Copy link
Contributor Author

cm-iwata commented Jan 4, 2023

@cm-iwata The PR needs to be rebased, could you please rebase onto main.

@JonathanWoollett-Light
rebased!

Maybe I need update other architectures coverage.
But, I don't have devenv.
Could you rerun ci job?

@JonathanWoollett-Light
Copy link
Contributor

@cm-iwata The PR needs to be rebased, could you please rebase onto main.

@JonathanWoollett-Light rebased!

Maybe I need update other architectures coverage. But, I don't have devenv. Could you rerun ci job?

CI has been re-run.

Signed-off-by: Tomoya <iwata.tomoya@classmethod.jp>
@cm-iwata
Copy link
Contributor Author

cm-iwata commented Jan 4, 2023

CI has been re-run.

@JonathanWoollett-Light
Thank you!
re updated coverage.

@cm-iwata cm-iwata requested a review from dianpopa January 4, 2023 14:44
@dianpopa dianpopa merged commit 306c6aa into firecracker-microvm:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants