feat: Add "cpu-config" field to config file #3614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulinx86
force-pushed
the
cpu_config_in_json
branch
2 times, most recently
from
d563373
to
863204b
Compare
zulinx86
changed the title
kalyazin
force-pushed
the
feature/cpu-templates
branch
from
e9d3080
to
c8ac5b0
Compare
zulinx86
force-pushed
the
cpu_config_in_json
branch
4 times, most recently
from
67acef0
to
ee5c9d0
Compare
zulinx86
added
the
Status: Awaiting review
zulinx86
changed the title
ShadowCurse
reviewed
Apr 26, 2023
zulinx86
force-pushed
the
cpu_config_in_json
branch
2 times, most recently
from
cae0c05
to
fb17c7d
Compare
kalyazin
reviewed
Apr 26, 2023
"cpu-config" PUT API was added in PR firecracker-microvm#3547 to set custom CPU template via API socket. To accept custom CPU templates without API, this commit adds a new "cpu-config" field into the existing config file. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
zulinx86
force-pushed
the
cpu_config_in_json
branch
from
fb17c7d
to
3bf3c8a
Compare
kalyazin
approved these changes
Apr 27, 2023
ShadowCurse
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reason
"cpu-config" PUT API was added in PR #3547 to set custom CPU template via API socket. Need to add the field to accept custom CPU template without API
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] If a specific issue led to this PR, this PR closes the issue.[ ] Any required documentation changes (code and docs) are included in this PR.[ ] API changes follow the Runbook for Firecracker API changes.[ ] User-facing changes are mentioned inCHANGELOG.md.[ ] NewTODOs link to an issue.rust-vmm.