Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: m6a vsock throughput baselines #3617

Merged
merged 2 commits into from
Apr 19, 2023
Merged

test: m6a vsock throughput baselines #3617

merged 2 commits into from
Apr 19, 2023

Conversation

JonathanWoollett-Light
Copy link
Contributor

@JonathanWoollett-Light JonathanWoollett-Light commented Apr 17, 2023 •
edited
Loading

Changes

Re-gathered m6a.metal vsock throughput performance test baselines to incorporate a performance improvement.

Reason

Failing CI due to out of date performance numbers.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.
  • This functionality cannot be added in rust-vmm.

@JonathanWoollett-Light JonathanWoollett-Light added Priority: High Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Fix Indicates a fix to existing code labels Apr 17, 2023
@JonathanWoollett-Light
test: m6a vsock throughput baselines
b4bdee6 
Re-gathered m6a.metal vsock throughput performance test baselines to
incorporate a performance improvement.

Signed-off-by: Jonathan Woollett-Light <jcawl@amazon.co.uk>
pb8o
pb8o approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@pb8o pb8o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to run compare_baselines here.

@pb8o pb8o merged commit dd5aaba into firecracker-microvm:main Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pb8o pb8o pb8o approved these changes

@roypat roypat roypat approved these changes

Assignees

@JonathanWoollett-Light JonathanWoollett-Light

Labels
Priority: High Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Fix Indicates a fix to existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JonathanWoollett-Light @pb8o @roypat