Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update recommendation on ENOMEM #3624

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Conversation

pb8o
Copy link
Contributor

@pb8o pb8o commented Apr 21, 2023

The recommendation to patch and recompile a kernel is dubious. Instead, let's suggest some more mainstream approaches.

Changes

...

Reason

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@pb8o pb8o self-assigned this Apr 21, 2023
@pb8o pb8o added Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Documentation Indicates a need for improvements or additions to documentation labels Apr 21, 2023
The recommendation to patch and recompile a kernel is quite extreme.
Instead, let's suggest some more mild approaches.

Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
@pb8o pb8o merged commit 22b83e6 into firecracker-microvm:main Apr 21, 2023
1 check passed
@pb8o pb8o deleted the doc-enomem branch April 21, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Documentation Indicates a need for improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants