Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(test): Delete duplicate function definition #3752

Merged
merged 4 commits into from May 30, 2023
Merged

refactor(test): Delete duplicate function definition #3752

merged 4 commits into from May 30, 2023

Conversation

cm-iwata
Copy link
Contributor

Changes

The function get_kernel_version used to get the host operating system kernel version was duplicated.
I removed the duplication.

Reason

this PR will close #3751

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.
  • This functionality cannot be added in rust-vmm.

@roypat roypat self-requested a review May 30, 2023 08:52
@roypat
Copy link
Contributor

roypat commented May 30, 2023

Hi @cm-iwata,thanks for fixing this! Could you please add a body to your commit message?

@cm-iwata
refactor(test): Delete duplicate function definition
7250cbe 
The function `get_kernel_version` was defined twice
in two different places.

Signed-off-by: Tomoya <iwata.tomoya@classmethod.jp>
@cm-iwata cm-iwata force-pushed the refactor/del-duplicate-get-kernel-ver branch from 53c533e to 7250cbe Compare May 30, 2023 10:00
@cm-iwata
Copy link
Contributor Author

Hi @cm-iwata,thanks for fixing this! Could you please add a body to your commit message?

@roypat
Fixed commit message and confirmed that test_gitlint.py completed successfully
Is this all right?

@roypat
Copy link
Contributor

roypat commented May 30, 2023

Hi @cm-iwata,thanks for fixing this! Could you please add a body to your commit message?

@roypat Fixed commit message and confirmed that test_gitlint.py completed successfully Is this all right?

Looks good now, thanks!

@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label May 30, 2023
@roypat roypat merged commit 49e553b into firecracker-microvm:main May 30, 2023
4 checks passed
@cm-iwata cm-iwata deleted the refactor/del-duplicate-get-kernel-ver branch February 8, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattschlebusch mattschlebusch mattschlebusch approved these changes

@roypat roypat roypat approved these changes

Assignees
No one assigned
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The function get_kernel_version is defined twice in two different places.
4 participants
@cm-iwata @roypat @mattschlebusch @zulinx86