vmm: Deprecate static CPU templates #4126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulinx86
force-pushed
the
depr_static_templates
branch
2 times, most recently
from
6e86a93
to
b8d6b66
Compare
zulinx86
changed the title
zulinx86
force-pushed
the
depr_static_templates
branch
3 times, most recently
from
6edb796
to
bfa2afb
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4126 +/- ##
==========================================
- Coverage 83.12% 83.10% -0.03%
==========================================
Files 225 225
Lines 28581 28604 +23
==========================================
+ Hits 23758 23771 +13
- Misses 4823 4833 +10
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
zulinx86
force-pushed
the
depr_static_templates
branch
2 times, most recently
from
ab5d750
to
1a6ba57
Compare
zulinx86
requested review from
xmarcalx,
kalyazin,
pb8o and
sudanl0
as code owners
zulinx86
force-pushed
the
depr_static_templates
branch
3 times, most recently
from
59cc7f7
to
b264d55
Compare
zulinx86
force-pushed
the
depr_static_templates
branch
4 times, most recently
from
4ff2c99
to
8b4c3b2
Compare
zulinx86
added
the
Status: Awaiting review
roypat
reviewed
Sep 27, 2023
zulinx86
force-pushed
the
depr_static_templates
branch
from
8b4c3b2
to
5bc9599
Compare
kalyazin
reviewed
Sep 27, 2023
zulinx86
force-pushed
the
depr_static_templates
branch
2 times, most recently
from
8a27695
to
c38966e
Compare
As different indentation styles of raw JSON strings were being used, unify them into the 4 spaces indentation. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
Make unit tests more idiomatic by using `assert_eq!()` rather than `match` + `panic!()`. With this, `#[allow(clippy::match_wild_err_arm)]` can be removed. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
`tests/framework/resources.py` was removed in commit dc7aabd ("test: refactor Firecracker HTTP API client") and the description in the practial example of API changes is already stale. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
Different wordings were used as description for deprecation. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
Add an implementation of conversion from `&CpuTemplateType` to `Option<StaticCpuTemplate>`, which will be used in a successive commit to deprecate the `cpu_template` field in the `/machine-config` API. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
zulinx86
force-pushed
the
depr_static_templates
branch
from
c38966e
to
03cde8b
Compare
roypat
previously approved these changes
Sep 28, 2023
Deprecate the `cpu_template` field in PUT and PATCH reqeusts on the `/machine-config` API by following the runbook for API changes. To differentiate between explicitly specifying `None` and not specifying anything, wrap the `cpu_template` of the `MachineConfig` with `Option`. With this, it can notify the deprecation of only users using the field. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
zulinx86
force-pushed
the
depr_static_templates
branch
from
03cde8b
to
1c8885f
Compare
kalyazin
approved these changes
Sep 28, 2023
roypat
approved these changes
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Deprecate the
cpu_templatefield in the/machine-configAPI, which is used to set static CPU templates.Reason
Since v1.4.0, Firecracker has supported custom CPU templates that allows users to define their own CPU templates and can be used as an alternative of static CPU templates.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] If a specific issue led to this PR, this PR closes the issue.CHANGELOG.md.[ ] NewTODOs link to an issue.rust-vmm.