Enable per Block device metrics #4202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudanl0
force-pushed
the
block_metrics
branch
from
d82f384
to
f221848
Compare
sudanl0
force-pushed
the
block_metrics
branch
2 times, most recently
from
d63a01d
to
002bcb2
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4202 +/- ##
==========================================
+ Coverage 82.92% 82.96% +0.03%
==========================================
Files 221 222 +1
Lines 28235 28299 +64
==========================================
+ Hits 23414 23477 +63
- Misses 4821 4822 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
sudanl0
force-pushed
the
block_metrics
branch
8 times, most recently
from
f2209b5
to
0ca2420
Compare
sudanl0
force-pushed
the
block_metrics
branch
from
ed299cf
to
0ca2420
Compare
sudanl0
added
the
Status: Awaiting review
kalyazin
reviewed
Oct 30, 2023
sudanl0
force-pushed
the
block_metrics
branch
4 times, most recently
from
55fa526
to
5484ceb
Compare
sudanl0
force-pushed
the
block_metrics
branch
3 times, most recently
from
cefa970
to
8e9fc96
Compare
kalyazin
previously approved these changes
Oct 31, 2023
sudanl0
force-pushed
the
block_metrics
branch
from
8e9fc96
to
e48694f
Compare
To prepare for per block device metrics: - Move BlockDeviceMetrics from logger to Block module. - Define a global buffer to put per device block metrics. Signed-off-by: Sudan Landge <sudanl@amazon.com>
- Add metrics fs an field in Block{} to record metrics per block.
- Remove new() implementation of BlockDeviceMetrics since default
is enough.
- For each block device added, allocate a metrics struct in global
BLOCK_METRICS pool and save its pointer in Block::metrics.
- Use Block's self.metrics instead of the aggregated METRICS to
record per device block metrics.
- Pass self.metrics to finish() and write_status_and_finish() to
record per block device metrics.
Signed-off-by: Sudan Landge <sudanl@amazon.com>
Add a test that has multiple block devices and validate aggregate block metrics. Signed-off-by: Sudan Landge <sudanl@amazon.com>
Include per device block metrics in changelog. Signed-off-by: Sudan Landge <sudanl@amazon.com>
Add unit test for block inc metrics and shared metrics. Signed-off-by: Sudan Landge <sudanl@amazon.com>
test_cli_metrics_path and test_flush_metrics both validated breaking change in FC metrics so move the validation functions to host_tools which already had CI metrics related functions defined. Signed-off-by: Sudan Landge <sudanl@amazon.com>
sudanl0
force-pushed
the
block_metrics
branch
from
e48694f
to
c27703e
Compare
kalyazin
approved these changes
Oct 31, 2023
ShadowCurse
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add per device metrics for block device.
Reason
To add more granularity in block device metrics.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
- [ ] If a specific issue led to this PR, this PR closes the issue.- [ ] API changes follow the Runbook for Firecracker API changes.CHANGELOG.md.- [ ] NewTODOs link to an issue.rust-vmm.