Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify read_config #4458

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Simplify read_config #4458

merged 5 commits into from
Jun 10, 2024

Commits on May 20, 2024

  1. fix: Ensure ConfigSpace has stable layout 

    Rust doesn't guarantee struct layout by default, so `repr(C)` or
`repr(transparent)` are necessary for safety.

Signed-off-by: Kornel <kornel@cloudflare.com>
    @kornelski @roypat
    kornelski authored and roypat committed May 20, 2024
    Configuration menu
    Copy the full SHA
    489cdb7 View commit details
    Browse the repository at this point in the history

  2. refactor(virtio): Simplify read_config 

    From: Kornel <kornel@cloudflare.com>

`io::Write` has higher overhead and unnecessary error handling. Slices
can be copied without it.

Signed-off-by: Kornel <kornel@cloudflare.com>
Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Co-authored-by: Patrick Roy <roypat@amazon.co.uk>
    @kornelski @roypat
    kornelski and roypat committed May 20, 2024
    Configuration menu
    Copy the full SHA
    68cdc71 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into read-conf

    @roypat
    roypat committed May 20, 2024
    Configuration menu
    Copy the full SHA
    d339342 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2024

  1. Merge branch 'main' into read-conf

    @ShadowCurse
    ShadowCurse committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    096bc06 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2024

  1. Merge branch 'main' into read-conf

    @roypat
    roypat committed Jun 10, 2024
    Configuration menu
    Copy the full SHA
    21e5ab5 View commit details
    Browse the repository at this point in the history