Update micro-http for empty MMDS path handling #4468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulinx86
force-pushed
the
fix_empty_mmds_path
branch
from
7864c84
to
1a3f7e6
Compare
zulinx86
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4468 +/- ##
=======================================
Coverage 81.63% 81.63%
=======================================
Files 243 243
Lines 29789 29789
=======================================
Hits 24319 24319
Misses 5470 5470
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zulinx86
force-pushed
the
fix_empty_mmds_path
branch
from
1a3f7e6
to
6054cc9
Compare
zulinx86
requested review from
xmarcalx,
kalyazin,
pb8o and
sudanl0
as code owners
zulinx86
force-pushed
the
fix_empty_mmds_path
branch
from
6054cc9
to
f2194e2
Compare
roypat
previously approved these changes
Feb 21, 2024
pb8o
reviewed
Feb 21, 2024
zulinx86
force-pushed
the
fix_empty_mmds_path
branch
from
53108a6
to
b39b6a9
Compare
pb8o
previously approved these changes
Feb 21, 2024
Without this change, it ignores non-0 exits that don't print anything on stderr. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
zulinx86
force-pushed
the
fix_empty_mmds_path
branch
from
0892084
to
0831669
Compare
When querying a MMDS path that has an empty content, the response didn't contain 'Content-Length' field, resulting in the client waiting for the connection closed by the server or timeout. To fix this issue, micro-http made a change to have the field when the response status code is not 1XX or 204. This commit updates Cargo.lock file to consume this change and also adds an integration test to ensure that it doesn't timeout for an empty MMDS path. The micro-http's change was made on firecracker-microvm/micro-http#48. Signed-off-by: Takahiro Itazuri <itazur@amazon.com>
zulinx86
force-pushed
the
fix_empty_mmds_path
branch
from
0831669
to
33d1efc
Compare
roypat
approved these changes
Feb 21, 2024
pb8o
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reason
When querying a MMDS path that has an empty content, the response didn't
contain 'Content-Length' field, resulting in the client waiting for the
connection closed by the server or timeout. To fix this issue,
micro-http made a change to have the field when the response status code
is not 1XX or 204.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] If a specific issue led to this PR, this PR closes the issue.[ ] Any required documentation changes (code and docs) are included in thisPR.
[ ] API changes follow the Runbook for Firecracker API changes.CHANGELOG.md.[ ] NewTODOs link to an issue.contribution quality standards.
rust-vmm.