fix: Limit amount of memory used during snapshot deserialization #4480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
added
the
Status: Awaiting review
When switching from Versionize to bincode in firecracker-microvm#4230, we accidentally dropped a check limiting how much memory the deserialization routine can allocate [[1]]. This commit reimplements this check for the new bincode-based deserialization routine, with a limit matching that of the old Versionize check. [1]: https://github.com/firecracker-microvm/versionize/blob/main/src/primitives.rs#L14C33-L14C43 Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
roypat
requested review from
xmarcalx,
kalyazin,
pb8o and
sudanl0
as code owners
roypat
requested review from
bchalios and
ShadowCurse
and removed request for
kalyazin,
xmarcalx,
pb8o and
sudanl0
ShadowCurse
approved these changes
Mar 1, 2024
bchalios
approved these changes
Mar 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## firecracker-v1.7 #4480 +/- ##
=================================================
Coverage 81.62% 81.63%
=================================================
Files 243 243
Lines 29796 29803 +7
=================================================
+ Hits 24322 24329 +7
Misses 5474 5474
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When switching from Versionize to bincode in #4230, we accidentally dropped a check limiting how much memory the deserialization routine can allocate [1]. This commit reimplements this check for the new bincode-based deserialization routine, with a limit matching that of the old Versionize check.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.