fix: power off vcpus only during startup #4567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
added
Status: Awaiting review
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4567 +/- ##
==========================================
- Coverage 82.14% 82.13% -0.01%
==========================================
Files 255 255
Lines 31278 31274 -4
==========================================
- Hits 25692 25688 -4
Misses 5586 5586
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ShadowCurse
force-pushed
the
vcpu_power
branch
5 times, most recently
from
f48b03c
to
7b1e567
Compare
bchalios
previously approved these changes
Apr 25, 2024
roypat
reviewed
Apr 26, 2024
ShadowCurse
force-pushed
the
vcpu_power
branch
3 times, most recently
from
75206a5
to
2ec10ad
Compare
Vcpus should be in power off state during kernel boot, but during snapshot restore we do not need to power them off even thought kvm does not complain. To do this we stop applying the `KVM_ARM_VCPU_POWER_OFF` to the `kvi` during restore. Also if we need to store `kvi` in the state, do this before adding `KVM_ARM_VCPU_POWER_OFF` to it, so that during restore `kvi` will not have `KVM_ARM_VCPU_POWER_OFF` set. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
bchalios
approved these changes
Apr 26, 2024
roypat
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Do not power off vcpus during snapshot restore.
Reason
Vcpus should be in power off state during kernel boot, but during snapshot restore we do not need to power them off even thought kvm does not complain.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.