fix(snapshot): prevent an integer overflow when calculating TSC scaling #4606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb8o
added
Priority: Medium
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4606 +/- ##
=======================================
Coverage 82.13% 82.13%
=======================================
Files 255 255
Lines 31268 31269 +1
=======================================
+ Hits 25683 25684 +1
Misses 5585 5585
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roypat
reviewed
May 7, 2024
pb8o
commented
May 7, 2024
Because we are using u32 integer math when checking the TSC, it could happen that the value can overflow if the TSC value is very high, around 18GHz. While there is no processor on the market near that frequency, it's worth fixing this in case the snapshot gets corrupted somehow. Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
ShadowCurse
approved these changes
May 7, 2024
roypat
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because we are using u32 integer math when checking the TSC, it could happen that the value can overflow if the TSC value is very high, around 18GHz. While there is no processor on the market near that frequency, it's worth fixing this in case the snapshot gets corrupted somehow.
Changes
...
Reason
To make the snapshot implementation more robust
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.