tools/sandbox changes #4609
Merged
tools/sandbox changes #4609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb8o
added
the
Priority: Low
pb8o
added
the
Status: Awaiting author
Sandbox gains an option to specify CPU template. Default to no CPU template like before. Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
Installing iptables is not needed now, as it is part of the devctr. Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
This is a quality-of-life measure to automate processes and build scripts. Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
Some other software or cloud providers can make use of private IP space, which can result in a conflict. Ideally we would detect what block to use, but just changing the block is much simpler and quicker. Use the last /16 within the 10.x.x.x /8 to try to avoid these kind of conflicts. Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
The current `devtool sandbox` command uses our devctr . It is desirable to be able to run in the host OS directly when running performance tests or when troubleshooting. Add a command to run Firecracker natively, by installing the necessary Python packages. Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4609 +/- ##
=======================================
Coverage 82.13% 82.13%
=======================================
Files 255 255
Lines 31267 31267
=======================================
Hits 25682 25682
Misses 5585 5585
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pb8o
added
Status: Awaiting review
roypat
approved these changes
May 9, 2024
zulinx86
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Some recent changes that are useful while reproducing issues.
Reason
Improve Quality of life and Developer Experience
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.