fix(test): avoid parsing broken metrics lines #4613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb8o
added
Priority: Low
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4613 +/- ##
=======================================
Coverage 82.13% 82.13%
=======================================
Files 255 255
Lines 31267 31267
=======================================
Hits 25682 25682
Misses 5585 5585
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pb8o
force-pushed
the
test-fix-broken-metrics-lines
branch
2 times, most recently
from
397ebd4
to
22efacf
Compare
Since we expect the process to get killed by seccomp, it can happen that we get a partially written line that we cannot parse as JSON ([example][1]). [1]: https://buildkite.com/firecracker/pablob-perf-tests/builds/2362#018f6e9c-107a-4bab-9896-c6b761209e06/49-1183 Signed-off-by: Pablo Barbáchano <pablob@amazon.com>
pb8o
force-pushed
the
test-fix-broken-metrics-lines
branch
from
22efacf
to
af79a89
Compare
roypat
approved these changes
May 13, 2024
pb8o
added
Status: Awaiting review
pb8o
changed the title
bchalios
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Ignore metric lines that cannot be parsed.
Reason
Improve the stability of tests.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.