feat: use host network for docker #4614
Merged
+1
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4614 +/- ##
=======================================
Coverage 82.14% 82.14%
=======================================
Files 255 255
Lines 31282 31282
=======================================
Hits 25697 25697
Misses 5585 5585
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ShadowCurse
force-pushed
the
docker_host_net
branch
from
552f092
to
fd8f5c6
Compare
ShadowCurse
added
the
Status: Awaiting review
ShadowCurse
force-pushed
the
docker_host_net
branch
2 times, most recently
from
2320da6
to
c30a079
Compare
Use host network for docker. This prevents issues when network access inside the container is different from the host access. Signed-off-by: Egor Lazarchuk <yegorlz@amazon.co.uk>
ShadowCurse
force-pushed
the
docker_host_net
branch
from
c30a079
to
af73bfb
Compare
kalyazin
approved these changes
May 14, 2024
roypat
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Use host network for docker. This prevents issues when network access inside the container is different from the host access.
Reason
Docker default network bridge might be restricted by networking rules, which can result in builds inside docker fail to retrieve dependencies from the internet.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.