Eliminate a handful of unwraps from the codebase #4622
Merged
+42
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These unwraps were impossible to trigger due to preceding checks, but by using some patterns matching in the checks instead, we can eliminate them altogether. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Reduce number of unwraps/lock operations needed by using the `.entry()` API for more idiomatic code. Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Removes a handful of unwraps by slightly rearranging code (e.g. by using pattern matching to combine the fallible operation with the check that ensures it won't actually fail). Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4622 +/- ##
==========================================
- Coverage 82.14% 82.08% -0.06%
==========================================
Files 255 255
Lines 31285 31256 -29
==========================================
- Hits 25700 25658 -42
- Misses 5585 5598 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ShadowCurse
approved these changes
May 21, 2024
JonathanWoollett-Light
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Eliminate some unneeded use of unwrap from Firecracker.
Reason
While looking into the feasibility of #593, I stumbled across a few unwraps that were very simple to fix.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.