Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.8] chore: update kvm-bindings to 0.8.2 #4631

Conversation

roypat
Copy link
Contributor

@roypat roypat commented Jun 3, 2024

This version contains a performance improvement during deserialization that would negate the performance regression observed when updating to kvm-bindings 0.8.0 in f68a2ef.

Fixes: f68a2ef

Changes

...

Reason

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

This version contains a performance improvement during deserialization
that would negate the performance regression observed when updating to
kvm-bindings 0.8.0 in f68a2ef.

Fixes: f68a2ef
Signed-off-by: Patrick Roy <roypat@amazon.co.uk>
@roypat roypat changed the base branch from main to firecracker-v1.8 June 3, 2024 08:48
@roypat roypat changed the title chore: update kvm-bindings to 0.8.2 [1.8] chore: update kvm-bindings to 0.8.2 Jun 3, 2024
@roypat roypat added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Jun 3, 2024
Copy link

codecov bot commented Jun 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.14%. Comparing base (89bc704) to head (d99fa0f).

Additional details and impacted files
@@                Coverage Diff                @@
##           firecracker-v1.8    #4631   +/-   ##
=================================================
  Coverage             82.14%   82.14%           
=================================================
  Files                   255      255           
  Lines                 31285    31285           
=================================================
  Hits                  25700    25700           
  Misses                 5585     5585           
Flag Coverage Δ
4.14-c5n.metal 79.64% <ø> (ø)
4.14-c7g.metal ?
4.14-m5n.metal 79.63% <ø> (-0.01%) ⬇️
4.14-m6a.metal 78.85% <ø> (ø)
4.14-m6g.metal 76.70% <ø> (ø)
4.14-m6i.metal 79.63% <ø> (ø)
4.14-m7g.metal 76.70% <ø> (?)
5.10-c5n.metal 82.16% <ø> (ø)
5.10-c7g.metal ?
5.10-m5n.metal 82.14% <ø> (-0.01%) ⬇️
5.10-m6a.metal 81.45% <ø> (ø)
5.10-m6g.metal 79.47% <ø> (ø)
5.10-m6i.metal 82.14% <ø> (-0.01%) ⬇️
5.10-m7g.metal 79.47% <ø> (?)
6.1-c5n.metal 82.16% <ø> (ø)
6.1-c7g.metal ?
6.1-m5n.metal 82.15% <ø> (ø)
6.1-m6a.metal 81.45% <ø> (ø)
6.1-m6g.metal 79.46% <ø> (-0.01%) ⬇️
6.1-m6i.metal 82.14% <ø> (-0.01%) ⬇️
6.1-m7g.metal 79.46% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roypat roypat merged commit 5c17bc6 into firecracker-microvm:firecracker-v1.8 Jun 3, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants