Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix style in FAQ.md and add new item about memory allocation #543

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Conversation

aghecenco
Copy link
Contributor

No description provided.

raduweiss
raduweiss previously approved these changes Oct 29, 2018
FAQ.md Outdated Show resolved Hide resolved
FAQ.md Outdated Show resolved Hide resolved
FAQ.md Outdated Show resolved Hide resolved
FAQ.md Outdated Show resolved Hide resolved
Copy link
Member

@andreeaflorescu andreeaflorescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please limit the commit message summary to 50 characters.

@aghecenco
Copy link
Contributor Author

Commit message modified to fit within 50 chars

FAQ.md Outdated Show resolved Hide resolved
FAQ.md Outdated Show resolved Hide resolved
raduweiss
raduweiss previously approved these changes Oct 30, 2018
raduweiss
raduweiss previously approved these changes Oct 31, 2018
Copy link
Contributor

@raduweiss raduweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Content is solid. I have some word-smithing comments but since I will add more FAQ items in a few days, I will just make those edits rather than iterate again just for this.

and add new item about memory allocation failures

Signed-off-by: Alexandra Iordache <aghecen@amazon.com>
@aghecenco aghecenco merged commit 8d23277 into firecracker-microvm:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants