Fix hyperlink to public URI for a GitHub issue #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatangiu
reviewed
Nov 28, 2018
There was a problem hiding this comment.
Although all PRIVATE-firecracker links successfully redirect to the new repo location, this is a valid change that avoids confusion.
A grep through the repo for PRIVATE also shows
mmds/src/data_store.rs:40: // https://github.com/aws/PRIVATE-firecracker/issues/401
so it'd be great if you could also change that in this PR.
Seems like the Firecracker repo is now public at https://github.com/firecracker-microvm Signed-off-by: Tim Bannister <tim+github@scalefactory.com>
sftim
force-pushed
the
20181128_repo_uri_fix
branch
from
a9eae2e
to
ba4c48f
Compare
aghecenco
approved these changes
Nov 28, 2018
raduweiss
added
Documentation: Usage
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FAQ has a link a GitHub issue in what looks like a previous, private incarnation of this repo. Link to the current URI of that issue instead.