Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cofunction as possible input to Projector #3457

Open
colinjcotter opened this issue Mar 15, 2024 · 4 comments
Open

Add Cofunction as possible input to Projector #3457

colinjcotter opened this issue Mar 15, 2024 · 4 comments
Assignees

Comments

@colinjcotter
Copy link
Contributor

I’m thinking of adding support for v to be a Cofunction in Projector. This would allow easy implementation of explicit DG schemes using the Slate option for the inverse mass matrix. I could then assemble the DG RHS into a cofunction and use the projector to get the result of the RK stage.

Rationale is that I would otherwise be repeating a lot of that code. Just sounding out, if there is not strong objections then I will implement.

@connorjward
Copy link
Contributor

It might be good to flag this either on Slack or bring to the weekly meeting.

@dham
Copy link
Member

dham commented Mar 18, 2024

Isn't this just duplicating the riesz_representation() method of Cofunction?

@colinjcotter
Copy link
Contributor Author

It is, so maybe it is better to add SLATE options to riesz_representation(). The problem is that we end up duplicating code either way.

@dham
Copy link
Member

dham commented Mar 18, 2024

Well the really nice thing to do is probably to add Cofunction to Projector then replace the implementation of riesz_representation with a call to project thereby removing all code duplication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants