Periodic vertexonlymesh #2437
Merged
Periodic vertexonlymesh #2437
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe this is doing the "Quick" solution suggested in #2185 . |
Sure, and I think that's good. It's a small amount of work which makes a lot of things work that don't currently. I don't think it's at all worse than what we're currently doing, and I don't think we should refrain from improving the current situation in favour of a potential future fix. If we ever get there then reversing this change is very easy. |
ReubenHill
reviewed
May 12, 2022
ReubenHill
reviewed
May 12, 2022
ReubenHill
requested changes
May 12, 2022
ReubenHill
reviewed
May 12, 2022
wence-
reviewed
May 13, 2022
ReubenHill
reviewed
May 13, 2022
Also do our own halo elimination for free.
ReubenHill
previously requested changes
May 18, 2022
|
|
|
Great that this all passed tests and works though! Thanks for the PR 😃 |
ReubenHill
added a commit
that referenced
this pull request
Jan 18, 2023
Since we switched to doing cell location and point location using _parent_mesh_embedding, which relies on firedrake's notion of cells and point locations as opposed to using PETSc's DMPlex embedding via DMSwarmSetPointCoordinates (PR #2437), we ought to be able to support extruded meshes. After all, .at works on extruded meshes!
ReubenHill
added a commit
that referenced
this pull request
Feb 1, 2023
Since we switched to doing cell location and point location using _parent_mesh_embedding, which relies on firedrake's notion of cells and point locations as opposed to using PETSc's DMPlex embedding via DMSwarmSetPointCoordinates (PR #2437), we ought to be able to support extruded meshes. After all, .at works on extruded meshes!
ReubenHill
added a commit
that referenced
this pull request
Feb 8, 2023
Since we switched to doing cell location and point location using _parent_mesh_embedding, which relies on firedrake's notion of cells and point locations as opposed to using PETSc's DMPlex embedding via DMSwarmSetPointCoordinates (PR #2437), we ought to be able to support extruded meshes. After all, .at works on extruded meshes!
ReubenHill
added a commit
that referenced
this pull request
Feb 15, 2023
Since we switched to doing cell location and point location using _parent_mesh_embedding, which relies on firedrake's notion of cells and point locations as opposed to using PETSc's DMPlex embedding via DMSwarmSetPointCoordinates (PR #2437), we ought to be able to support extruded meshes. After all, .at works on extruded meshes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR swaps the order of mesh searching in the VertexOnlyMesh setup so that we do the Firedrake search for parent mesh cell inclusion before the PETSc one. We then use this to set up the swarm coordinates instead of calling
swarm.setPointCoordinates. This means that we're not dependent on Firedrake and DMPlex agreeing on how coordinates work.This needs a little cleanup and docstrings, and I need to do the parallel bounding box elimination (which isn't hard). I think the extension to extrusion is probably fairly straightforward and I think I might know how to do bendy.