Expunge Expr.ufl_domain Part II

[pbrubeck]

Description

This was still triggering warnings at interpolation (and when trying to output non-Lagrange functions).

[connorjward]

Looks sensible.

[JDBetteridge]

Hurrah, now we are only raising 13414 warnings on CI!

This is a massive improvement over the 20947 warnings we generated previously.

@pbrubeck do you fancy opening a similar PR to expunge this warning from UFL itself?

[pbrubeck]

Hurrah, now we are only raising 13414 warnings on CI!

This is a massive improvement over the 20947 warnings we generated previously.

@pbrubeck do you fancy opening a similar PR to expunge this warning from UFL itself?

I am not entirely sure we are completely eliminating these warnigns. Maybe I'll first open a ufl PR that fails instead of raising the warning to detect where else we need to change our code, and then open another PR to remove the warning.

[wence-]

Hurrah, now we are only raising 13414 warnings on CI!
This is a massive improvement over the 20947 warnings we generated previously.
@pbrubeck do you fancy opening a similar PR to expunge this warning from UFL itself?

I am not entirely sure we are completely eliminating these warnigns. Maybe I'll first open a ufl PR that fails instead of raising the warning to detect where else we need to change our code, and then open another PR to remove the warning.

you can either turn warnings into errors in pytest, or, if you run just a python script, do python -Werror --pdb script.py to turn warnings into errors and drop into the debugger: https://docs.python.org/3/using/cmdline.html#cmdoption-W

[pbrubeck]

We went down to 1249 warnings after making sure this warning is never triggered by the tests.

[connorjward]

Thanks for taking the time to do this.

[connorjward]

Just clearing up a strange bit of code. Otherwise fine.

done