Allow non-integer id's in JSON RPC requests #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fireduck64
added a commit
that referenced
this pull request
Mar 13, 2013
Allow non-integer id's in JSON RPC requests
|
Sounds good. Can you point me to this JSON RPC spec? Sounds like something I should read. |
|
This is the spec - not sure how many clients actually follow it though: http://www.jsonrpc.org/specification |
|
Wow, it took literally 3 seconds to find something that everyone is doing errorThis member is REQUIRED on error. On Wed, Mar 13, 2013 at 4:06 PM, Chris Double notifications@github.comwrote:
|
GuyPaddock
added a commit
to GuyPaddock/SockThing
that referenced
this pull request
May 3, 2020
- Coinbase is now maintained on the connection rather than the job, to enable extra nonce fireduck64#1 to be sent earlier in the stratum session.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've noticed some clients sending a non-numeric "id" in the JSON RPC request when doing a subscribe request. In particular one was sending the string "s". The JSON RPC spec allows numbers and strings.
This patch uses "optLong" instead of "getLong" to avoid failing with an exception, and where the "id" returned back to the client it uses "opt" to deal with whatever format the original request used.