Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not save similar rules #109

Merged
merged 2 commits into from
Feb 10, 2024
Merged

Conversation

zStupan
Copy link
Collaborator

@zStupan zStupan commented Feb 9, 2024

I've updated the equals method in Feature so numeric features are equal if their min and max values match within 6 decimal places.

This closes #103

Also, I updated the requirements file in the docs because there were build errors on readthedocs

@firefly-cpp
Copy link
Owner

Brilliant. Thanks. Can you also implement the same feature for Julia version of niaarm?

@firefly-cpp firefly-cpp merged commit 3a463cf into firefly-cpp:main Feb 10, 2024
12 checks passed
@firefly-cpp
Copy link
Owner

@all-contributors please add @zStupan for code, bugs, docs, content, ideas, examples

Copy link
Contributor

@firefly-cpp

I've put up a pull request to add @zStupan! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not save "similar rules"
2 participants