Include BIC in import routine

firefly-iii · Mar 19, 2018 · e2ecaf5 · e2ecaf5
1 parent 3114695
commit e2ecaf5
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 1 deletion.
diff --git a/app/Import/Object/ImportAccount.php b/app/Import/Object/ImportAccount.php
@@ -38,6 +38,8 @@ class ImportAccount
     /** @var Account */
     private $account;
     /** @var array */
+    private $accountBic = [];
+    /** @var array */
     private $accountIban = [];
     /** @var array */
     private $accountId = [];
@@ -51,7 +53,7 @@ class ImportAccount
     private $expectedType = '';
     /**
      * This value is used to indicate the other account ID (the opposing transaction's account),
-     * if it is know. If so, this particular importaccount may never return an Account with this ID.
+     * if it is know. If so, this particular import account may never return an Account with this ID.
      * If it would, this would result in a transaction from-to the same account.
      *
      * @var int
@@ -105,6 +107,14 @@ public function setExpectedType(string $expectedType)
         $this->expectedType = $expectedType;
     }
 
+    /**
+     * @param array $accountBic
+     */
+    public function setAccountBic(array $accountBic): void
+    {
+        $this->accountBic = $accountBic;
+    }
+
     /**
      * @codeCoverageIgnore
      *
@@ -388,6 +398,7 @@ private function store(): bool
             'active'          => true,
             'virtualBalance'  => '0',
             'account_type_id' => null,
+            'BIC'             => $this->accountBic['value'] ?? null,
         ];
 
         $this->account = $this->repository->store($data);

diff --git a/app/Import/Object/ImportJournal.php b/app/Import/Object/ImportJournal.php
@@ -283,6 +283,9 @@ public function setValue(array $array)
             case 'opposing-id':
                 $this->opposing->setAccountId($array);
                 break;
+            case 'opposing-bic':
+                $this->opposing->setAccountBic($array);
+                break;
             case 'tags-comma':
             case 'tags-space':
                 $this->setTags($array);

diff --git a/config/csv.php b/config/csv.php
@@ -266,6 +266,12 @@
             'converter'       => 'AccountId',
             'mapper'          => 'OpposingAccounts',
         ],
+        'opposing-bic'       => [
+            'mappable'        => false,
+            'pre-process-map' => false,
+            'field'           => 'opposing-account-bic',
+            'converter'       => 'AccountBic',
+        ],
         'opposing-name'     => [
             'mappable'        => true,
             'pre-process-map' => false,