API To change transaction fails to find destination_id

[soloam]

Support guidelines

• I've read the support guidelines

I've found a bug and checked that ...

• ... the documentation does not mention anything about my problem
• ... there are no open or closed issues that are related to my problem
• ... it's definitely a Firefly III issue, not me

Description

When I do a PUT to update a trsnasaction I inform

{ "apply_rules": false, "fire_webhooks": false, "transactions": [ { "type": "transfer", "source_id": 7, "destination_id": 13 } ] }

This fails with error:

{ "message": "Não foi possível encontrar uma conta de destino válida ao pesquisar pelo ID \"13\" ou nome \"\". (and 1 more error)", "errors": { "transactions.0.destination_id": [ "Não foi possível encontrar uma conta de destino válida ao pesquisar pelo ID \"13\" ou nome \"\"." ], "transactions.0.destination_name": [ "Não foi possível encontrar uma conta de destino válida ao pesquisar pelo ID \"13\" ou nome \"\"." ] } }

Stating that it cant find a destination account with the number 13.

But If I supply the account name destination_name, it works and the transaction is done to the account with the id 13

Thank You

Debug information

{ "message": "Não foi possível encontrar uma conta de destino válida ao pesquisar pelo ID \"13\" ou nome \"\". (and 1 more error)", "errors": { "transactions.0.destination_id": [ "Não foi possível encontrar uma conta de destino válida ao pesquisar pelo ID \"13\" ou nome \"\"." ], "transactions.0.destination_name": [ "Não foi possível encontrar uma conta de destino válida ao pesquisar pelo ID \"13\" ou nome \"\"." ] } }

Expected behaviour

It sould assume the destination_id 13 and do the update

Steps to reproduce

1. Make a withdrawal transfer
2. In the API PUT /api/v1/transactions/<> call with:
   { "apply_rules": false, "fire_webhooks": false, "transactions": [ { "type": "transfer", "source_id": <<source id>>, "destination_id": <<destination id>> } ] }

Additional info

No response

[JC5]

You can't convert a transaction into a transfer like that. So this is not a bug.

[soloam]

No? But if I do with destination_name instead destination_id it works and changes the type to transfer!

[JC5]

It doesn't when I do it, it remains a withdrawal. Even though it does, mistakenly, make a transaction between two asset accounts. It keeps calling it a withdrawal. I'll pick it up!

Edit: for another transaction, it does. Very strange!

[JC5]

#6868

[soloam]

I'm using this a lot, I detect with a script if a withdrawal is a transfer, and I change it with the api! It works ok, but I have to inform the destination_name, because if I do it with destination_id it does not work

[JC5]

And it's not supposed to, lol. It's buggy and I'm working on another solution. This "feature" will stop working in the next release.

[soloam]

Will it stop working but will it have a alternative way to do it? Because I depend a lot on this to manage my transactions!

[JC5]

Absolutely, but it will be a new endpoint that doesn't exist yet. Sorry about that.

[soloam]

No problem, I'll adjust my script to call the new endpoint! Tks