Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small withdrawals aren't counted #1000

Closed
xpfgsyb opened this issue Nov 17, 2017 · 2 comments
Closed

Small withdrawals aren't counted #1000

xpfgsyb opened this issue Nov 17, 2017 · 2 comments
Assignees
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Milestone

Comments

@xpfgsyb
Copy link

xpfgsyb commented Nov 17, 2017

I am running Firefly III version 4.6.10

Description of my issue:

If I create a new withdrawal with a small number like 0.00000233, Firefly doesn’t count the payment. I can see the payment in the expenses, but it shows 0.00000000. The balance of the account doesn’t change too. If I try to edit the payment I get the error “Trying to get property of non-object”. Deleting the payment doesn’t work either. This happens to numbers smaller than 0.0001. It's not a rounding problem as a number of 0.09980233 is counted as it is.

Funnily a deposit with the same value does work without a problem. This is reproducible on your demo instance too.

Steps to reproduce

Create a currency with more than 4 decimals. Add a withdrawal with a value below 0.0001.

JC5 added a commit that referenced this issue Nov 18, 2017
@JC5
Copy link
Member

JC5 commented Nov 18, 2017

Nice find! Also, issue 1000, congrats 🎉 ;)

I can see that some views work but others do not. I have pushed some fixes to the demo site that should fix some of these issues but I've yet to fix the charts, this is a little more complex.

@JC5 JC5 self-assigned this Nov 18, 2017
@JC5 JC5 added the bug Verified and replicated bugs and issues. label Nov 18, 2017
JC5 added a commit that referenced this issue Nov 18, 2017
@JC5 JC5 added this to the 4.6.11 milestone Nov 19, 2017
@JC5 JC5 added the fixed Bugs that are fixed (in a coming release). label Nov 25, 2017
@JC5
Copy link
Member

JC5 commented Nov 25, 2017

Unfortunately I cannot fix all the charts, especially when they use mixed currencies. I believe I have fixed all other problems. The next release is next week. Let me know if you find any lingering issues.

@JC5 JC5 closed this as completed Nov 25, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants