Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next expected bill date #1029

Closed
zjean opened this issue Dec 1, 2017 · 1 comment
Closed

Next expected bill date #1029

zjean opened this issue Dec 1, 2017 · 1 comment
Assignees
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Milestone

Comments

@zjean
Copy link
Contributor

zjean commented Dec 1, 2017

I am running Firefly III version 4.6.11

Description of my issue:

The next expected bill date on /bills is different from bills/show. The latter seems correct.

Steps to reproduce

Check the demo site:

Index:
image

Show:
image

In code I see difference between the index method

$bill->nextExpectedMatch = $repository->nextExpectedMatch($bill, $lastDate);
and the show method
$bill->nextExpectedMatch = $repository->nextExpectedMatch($bill, new Carbon);
method.

Other important details (log files, system info):

Please visit the /debug page to get extra debug information.

JC5 added a commit that referenced this issue Dec 2, 2017
@JC5
Copy link
Member

JC5 commented Dec 2, 2017

I've pushed some fixes to make this more consistent. It should now report the correct date. It's live on the demo site, and I welcome your feedback!

@JC5 JC5 self-assigned this Dec 2, 2017
@JC5 JC5 added the bug Verified and replicated bugs and issues. label Dec 2, 2017
@JC5 JC5 added this to the 4.6.11.1 milestone Dec 2, 2017
@JC5 JC5 added the fixed Bugs that are fixed (in a coming release). label Dec 5, 2017
@JC5 JC5 closed this as completed Dec 8, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants