Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard charts don't show in French language #1030

Closed
Traxxi opened this issue Dec 1, 2017 · 11 comments
Closed

Dashboard charts don't show in French language #1030

Traxxi opened this issue Dec 1, 2017 · 11 comments
Assignees
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Milestone

Comments

@Traxxi
Copy link

Traxxi commented Dec 1, 2017

I am running Firefly III version 4.6.11

Description of my issue:

Since the 4.6.11 version, the dashboard's charts and "counters" ("Balance", "Bills to pay", etc.) don't show when language is set to french. (some JS errors?)
It's ok with all other languages.
Charts on other pages seems to work.

Steps to reproduce

Change the language setting and come back to the dashboard.
This happens on demo site too.

Other important details (log files, system info):

And thank you so much for this amazing app !! it's just a wonderful work ! :)

JC5 added a commit that referenced this issue Dec 2, 2017
@JC5
Copy link
Member

JC5 commented Dec 2, 2017

Thanks for the compliments!

I can confirm your bug. I forgot to escape the text. I shall push a new release end of next week that will fix this. The demo site in the meantime works again. You'll have to use the English variant for now.

@JC5 JC5 self-assigned this Dec 2, 2017
@JC5 JC5 added bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release). labels Dec 2, 2017
@JC5 JC5 added this to the 4.6.11.1 milestone Dec 2, 2017
@JC5 JC5 closed this as completed Dec 8, 2017
@naber
Copy link

naber commented Jun 29, 2018

Hi,
I am using Version 4.7.4 and same problem using Turkish language.

@JC5
Copy link
Member

JC5 commented Jun 29, 2018

Which charts do not work, exactly? I cannot replicate the problem.

@naber
Copy link

naber commented Jun 29, 2018

Hi,
i attached screenshot below. Can you look at.
screenshot_20180629-212001
screenshot_20180629-211929

@naber
Copy link

naber commented Jun 29, 2018

Also not work desktop versiyon.

@naber
Copy link

naber commented Jun 29, 2018

hi again,

when Turkish
canvas id="accounts-chart" height="400" width="100%" style="width: 100%; height: 400px;" class="general-chart-error"

2018-06-29 22_35_50-neler oluyor_ firefly iii

@JC5
Copy link
Member

JC5 commented Jun 29, 2018

Please share the console and any log errors you see in your Firefly III log files.

@naber
Copy link

naber commented Jun 29, 2018

Hi again,
I also updated Turkish translation.

ff3-litespeed-2018-06-29 (1).log

@JC5
Copy link
Member

JC5 commented Jun 30, 2018

I suspect that the files you have edited have not been saved as UTF-8.

If you are on Windows, use Notepad++ to "Save with encoding" or "Save as UTF-8". Or download the original Turkish files from the site.

@naber
Copy link

naber commented Jun 30, 2018

Himmm, i used to softaculous installer. And i think we need to all turkish files change to save as utf-8 an source.

@JC5
Copy link
Member

JC5 commented Jun 30, 2018

They are. I am not sure what Softaculous does but they shouldn't change the encoding.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

3 participants