Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question regarding imports #1045

Closed
AndreiGavriliu opened this issue Dec 9, 2017 · 8 comments
Closed

Question regarding imports #1045

AndreiGavriliu opened this issue Dec 9, 2017 · 8 comments
Assignees
Labels
fixed Bugs that are fixed (in a coming release).

Comments

@AndreiGavriliu
Copy link

I am running Firefly III version 4.6.11.1

This is just a question, not an issue or a feature request

Description of my issue:

I was trying to import with a pre-formatted notes (sepa-debet) field with markdown like this:

Attachments:

(none)

Original description:

dafhjkhdf aklsjfaklsdfjaskldfjha lkajaf lk fa f asdfafs a

I use a bash script to manipulate my bank statements as they are not really user-friendly, so adding some extra \n to the field was no problem.

  • I noticed the finished import-csv was created correctly, I could see the new lines (not the characters) and all the # and _
  • FF even showed the titles and italic texts correctly after the import
  • however, the new lines / line breaks were missing.

Is FF escaping them somehow during the import?

JC5 added a commit that referenced this issue Dec 9, 2017
@JC5
Copy link
Member

JC5 commented Dec 9, 2017

The current CSV library strips these. I've pushed an updated composer.json file that will update this library from v8 to v9. It should no longer happen in the updated version.

thephpleague/csv#124

Once you do a git pull you should run composer update to install it.
This is a major version update however and I haven't tested if Firefly III will remain working with it. So no guarantees, yet ;)

@JC5 JC5 self-assigned this Dec 9, 2017
@JC5 JC5 added the question label Dec 9, 2017
@AndreiGavriliu
Copy link
Author

I updated as described. I’ll check it out and let you know. Thanks!

@JC5
Copy link
Member

JC5 commented Dec 19, 2017

I believe this is working as expected, isn't it? I recall you have a daily cronjob :)

@JC5 JC5 closed this as completed Dec 19, 2017
@AndreiGavriliu
Copy link
Author

Hi,

sorry, was busy with Christmas-stuff. I updated everything as described:

The csv-column file looks like this:

[...];

##Attachments##

_(none)_

sadhsilfh lsf asldfg asljdhfg kasdjhfg askdjfg askjhfg sa
;[...]

The transaction imported correctly, everything looks fine, except the notes field, it is empty. Any suggestions?

@JC5
Copy link
Member

JC5 commented Dec 21, 2017

Make sure it is encased in quotes.

[..],"Some note", [..]
[..],"Some multi
line note", [..]

That should fix it. Also, there is now the option to select the "Note" field. I remembered I promised to add it.

JC5 added a commit that referenced this issue Dec 21, 2017
@AndreiGavriliu
Copy link
Author

I’ll give it a try tomorrow. I’m sure it will work now.

Regarding the notes field, thanks! It’s like an early Christmas present!

@AndreiGavriliu
Copy link
Author

Quick question: what will happen to the “notes” imported into the sepa-debet field? Would I have to “move” them via SQL? Or does FF just “concat” both columns into the new notes field?

@JC5
Copy link
Member

JC5 commented Dec 21, 2017

They're all concatenated into the same note.

@JC5 JC5 added the fixed Bugs that are fixed (in a coming release). label Dec 27, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants