-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem when upgrading to 4.6.12 on Windows #1083
Comments
There is a command in the composer file that is Linux only. I suggest you remove line 102 from composer.json (starts with |
Great, that worked. Thanks for the fast support (as always!) |
Yep. I had not realized people use Windows. I'll see what I can do. I can either break A or break B and I need to find a middle road. |
Could you execute this on your windows machine, see what happens? php -r 'if (!(getenv("DYNO"))===false){echo "dyno";}else{echo "no dyno\n";}' |
I've tried out of curiosity on my system (Win 10) although I don't run Firefly III on it:
|
OK, strange since Laravel's composer file uses this structure as well. If you have the time, could you try to see what happens when you update composer.json with this?
This is the same format as Laravel uses and I would expect it to work. |
I'm not sure if you noticed that I'm not the original reporter 😉 Also I'm not sure why you think that this is strange. Original command didn't work, because Windows doesn't understand apostrophes ( I don't have composer on Windows, so I've executed pre-install-cmd manually and it works as you expect. Setup:
It displays message when DYNO is not set:
It copies file when DYNO is set:
It doesn't overwrite file when it exists:
|
Yes, I noticed. I was hoping that @skuzzle would reply as well. As far as I can see the script works as expected. I just hope the format when used from composer.json works as well. |
I've tried it now but unfortunately it still seems flawed. I added the pre-install-cmd into the composer.jso excatly as you stated and ran
|
Strange, since the Laravel command is equal. I'll get my hands on a Windows machine and do some tinkering. |
Sorry to chime in. From my little experiment on my platform (win 10, php 7.1) seems like it's the line break
replacing
(Of course I haven't tested this on other platforms (e.g. Windows Server, Linux, or a Heroku setup) so I'm not sure if that's the ultimate cross-platform solution. Just hope it might shed some light.) // By the way, if I may add |
If it is, then problem solved! Thank you for providing me with the feedback! 😁 @skuzzle and @pkoziol, perhaps you can try as well? I don't particularly need the else-statement so I might drop it completely. The entire line would be come:
|
That seems to do the trick:
I'm not sure though whether it is correct that the php command is actually printed to the console |
Release is live, issue will be closed. |
I am running Firefly III version 4.6.11.1 on Windows Server with nginx and php 7.1
Description of my issue:
I was trying to upgrade to the latest version 4.6.12 but encountered an error during the compoer create-project step. It seems like it does not download all the required files:
The subsequent
artisan
calls fail with messages similar to this:The
vendor
folder is completely missing in the filrefly-update directory. Any ideas on this one?The text was updated successfully, but these errors were encountered: