Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change language of login page #1090

Closed
Findus23 opened this issue Jan 2, 2018 · 3 comments
Closed

Change language of login page #1090

Findus23 opened this issue Jan 2, 2018 · 3 comments
Assignees
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).
Milestone

Comments

@Findus23
Copy link
Contributor

Findus23 commented Jan 2, 2018

I am running Firefly III version 4.6.12.

Maybe that's a stupid question or has been asked before, but I just noticed that the Login (and 2FA) pages are always displayed in English for me. This makes sense as the language is a user setting and before logging in Firefly can't know my Language.
But if all users of an instance are speaking the same language it would be nice if one could set a default locale (or respect Accept-Language).

@JC5
Copy link
Member

JC5 commented Jan 2, 2018

I can add the strings from these files to the translation files. That way, I think at least the 2FA page will pick up on it (at that point FF3 knows which user it is and can pick up on preferences).

Others pages will not, unless you change the locale config var in config/app.php yourself (at your own peril). If you set it to de_DE Firefly III will default to German.

Firefly III will not be responding to the Accept-Language header, especially not for logged in users. For other users, using English on one page should not be that big of a deal. 😉

JC5 added a commit that referenced this issue Jan 2, 2018
@Findus23
Copy link
Contributor Author

Findus23 commented Jan 2, 2018

As it took me a few months of using Firefly to notice it, I guess it really isn't important. I just thought I had missed an option.

@JC5 JC5 self-assigned this Jan 2, 2018
@JC5 JC5 added enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release). labels Jan 2, 2018
@JC5 JC5 modified the milestones: 4.7.0, 4.6.13 Jan 2, 2018
@JC5
Copy link
Member

JC5 commented Jan 7, 2018

Release is live, issue will be closed.

@JC5 JC5 closed this as completed Jan 7, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants