Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't translate some strings #1098

Closed
Nik-vr opened this issue Jan 6, 2018 · 12 comments
Closed

Can't translate some strings #1098

Nik-vr opened this issue Jan 6, 2018 · 12 comments
Assignees
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).
Milestone

Comments

@Nik-vr
Copy link

Nik-vr commented Jan 6, 2018

I can't translate some strings.

"Initial balance for [asset_account_name]" on Dashboard and account's history.

PS. Please add Russian language to list on options page (now I need to edit firefly.php to add this). Also, add, please, Russian Ruble to default currencies list.

@JC5
Copy link
Member

JC5 commented Jan 6, 2018

The Russian Ruble is already in the currencies list. It will only be added to new installations, so if you do not have it right now, you can add it yourself under Options > Currencies.

I shall add the requested string to the language files. Currently, Russian is only at 33%, and I would like it to be at 75% before I can add it.

If you have a lot of strings you have translated already, send them to me over email and I shall update Crowdin.

JC5 added a commit that referenced this issue Jan 6, 2018
@JC5 JC5 self-assigned this Jan 6, 2018
@JC5 JC5 added this to the 4.7.0 milestone Jan 6, 2018
@JC5 JC5 added enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release). labels Jan 6, 2018
@Nik-vr
Copy link
Author

Nik-vr commented Jan 6, 2018

I created the currency "Russian ruble" back in the old version. If it exists in the new version, it's good.

Now I'm translating FirFly hrough Crowdin. Please approve new lines.

@JC5 JC5 modified the milestones: 4.7.0, 4.6.13 Jan 6, 2018
@Nik-vr
Copy link
Author

Nik-vr commented Jan 7, 2018

On the "Rules" page 2 lines are not translated. I translate it in the file firefly.php (see on crowdin), but they are displayed in English.

rules-page

@JC5
Copy link
Member

JC5 commented Jan 7, 2018

That rule group, and its description, is created when you first visit the /rules page. If it was in English back then, it will be saved in English.

When you delete all of your rules and visit the page again, they will be recreated in Russian.

@Nik-vr
Copy link
Author

Nik-vr commented Jan 7, 2018

Thank you! I recreate all rules, and now all OK.

@Nik-vr Nik-vr closed this as completed Jan 7, 2018
@Nik-vr
Copy link
Author

Nik-vr commented Jan 7, 2018

PS. I translated 75% of the text into Russian :)

There are texts left for correct translation of which I need to study in more detail the corresponding functions of the FireFly.

@Nik-vr
Copy link
Author

Nik-vr commented Jan 8, 2018

All the strings on the login page remain in English. All of these strings are translated in the file firefly.php.

login-form

@Nik-vr Nik-vr reopened this Jan 8, 2018
@JC5
Copy link
Member

JC5 commented Jan 8, 2018

That is correct. At this point you are not logged in, so Firefly does not know you are Russian. You can force Firefly to show this page in Russian by changing the locale setting in config/app.php.

@Nik-vr
Copy link
Author

Nik-vr commented Jan 8, 2018

Hmm ... It turns out that these strings are in the localization files, but not used?
Maybe it would be more logical to translate the input form if one user mode is on and the language is selected for it?

@Nik-vr
Copy link
Author

Nik-vr commented Jan 8, 2018

String "Select all" are not in the files for translation.

reports-page

@JC5
Copy link
Member

JC5 commented Jan 8, 2018

I'll make sure that "Select all" can be translated. The login I cannot help, I'm afraid. The only option is to change config/app.php.

@JC5
Copy link
Member

JC5 commented Jan 8, 2018

#1109

@JC5 JC5 closed this as completed Jan 8, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests for enhancements of existing stuff. fixed Bugs that are fixed (in a coming release).
Projects
None yet
Development

No branches or pull requests

2 participants