Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update weak password verifier to V2 #1187

Closed
pkoziol opened this issue Feb 21, 2018 · 2 comments
Closed

Update weak password verifier to V2 #1187

pkoziol opened this issue Feb 21, 2018 · 2 comments
Labels
enhancement Requests for enhancements of existing stuff.
Milestone

Comments

@pkoziol
Copy link
Contributor

pkoziol commented Feb 21, 2018

Troy Hunt just launched "Pwned Passwords" V2.

He recommends switching to the new domain:

Secondly, the existing API (that many people have created dependencies on!) still works just fine. It also points to the storage repository for V2 of the password set so it's now searching through the full half billion records. I'll leave this running for the foreseeable future, but if you are using it then I'd prefer you roll over to the endpoint on api.pwnedpasswords.com for the reasons mentioned above, and for these other reasons:

If you were using the original API via HTTP GET, rolling over to the new one changes absolutely nothing in your implementation other than the URL which will look like this:

GET https://api.pwnedpasswords.com/pwnedpassword/{password}

It'll still return HTTP 200 when a password is found and 404 when it's not.

But he also added new endpoint that improves user's anonymity by receiving only first 5 chars of the hash.

@JC5
Copy link
Member

JC5 commented Feb 22, 2018

I saw, thanks for the reminder! I’ll try to write a new check for the next release. The API is giving me some head aches though so it might not make it to 4.7.1.

@JC5 JC5 added the enhancement Requests for enhancements of existing stuff. label Feb 22, 2018
@JC5 JC5 added this to the 4.7.2 milestone Feb 26, 2018
JC5 added a commit that referenced this issue Mar 8, 2018
@JC5
Copy link
Member

JC5 commented Mar 8, 2018

This is now implemented and will be released with 4.7.2

@JC5 JC5 closed this as completed Mar 8, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests for enhancements of existing stuff.
Projects
None yet
Development

No branches or pull requests

2 participants