Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Show all transactions without grouping them by date"-Button not working on account page #1292

Closed
nicoschreiner opened this issue Mar 25, 2018 · 7 comments
Labels
bug Verified and replicated bugs and issues.
Milestone

Comments

@nicoschreiner
Copy link
Contributor

I am running Firefly III version 4.7.1.4

Description of my issue:

The Show the current period and overview-Button isn't working.
image
This problem also exists on the demo site.

Steps to reproduce

  1. open the detail-page of an account (Asset account, Expense account or Revenue accout).
  2. scroll down to the transaction-list
  3. notice a button which
    1. says Show the current period and overview instead of Show all transactions without grouping them by date. (see e.g the detail-page of a category)
    2. isn't working as expected (should show all transactions [first click] and then [second click] the current period - like the button in the category detail page)
JC5 added a commit that referenced this issue Mar 25, 2018
@JC5
Copy link
Member

JC5 commented Mar 25, 2018

Indeed, that code is a bit messy. I have pushed a fix to the demo site. Let me know if this is more in line with what you expected.

@JC5 JC5 added the bug Verified and replicated bugs and issues. label Mar 25, 2018
@nicoschreiner
Copy link
Contributor Author

It's better now, but I would expect the graphs to stay there (Like on the Category-Page). Currently they are removed if I click on Show all transactions without grouping them by date.

@JC5
Copy link
Member

JC5 commented Mar 25, 2018

Indeed. The top chart will be back, but the pie-charts won't.

JC5 added a commit that referenced this issue Mar 25, 2018
@nicoschreiner
Copy link
Contributor Author

Okay. But are you going to remove them in the Budget-Page too then? (Currently they are shown, if you click on Show all transactions without grouping them by date)

Just to be consistent with this 😄

@JC5
Copy link
Member

JC5 commented Mar 25, 2018

I think I will, they aren't very useful when there is so much data.

JC5 added a commit that referenced this issue Mar 25, 2018
@nicoschreiner
Copy link
Contributor Author

That's true 😃

@JC5 JC5 added this to the 4.7.2 milestone Mar 26, 2018
@JC5
Copy link
Member

JC5 commented Mar 26, 2018

Fixed 👍

@JC5 JC5 closed this as completed Mar 26, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified and replicated bugs and issues.
Projects
None yet
Development

No branches or pull requests

2 participants